Fix arch flag on i686-apple-darwin #105904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i686-apple-darwin should use `-arch i386` instead of `-arch i686`
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
T-bootstrap
|
Why exactly should |
Yes, that is correct. |
|
@bors r+ |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 21, 2022
…86, r=bjorn3 Fix arch flag on i686-apple-darwin i686-apple-darwin should use `-arch i386` instead of `-arch i686`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 21, 2022
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#105791 (docs: add long error explanation for error E0472) - rust-lang#105897 (Fix an opaque type ICE) - rust-lang#105904 (Fix arch flag on i686-apple-darwin) - rust-lang#105949 (Bump `cfg-if` to `1.0` in rustc crates) - rust-lang#105964 (rustdoc: prevent CSS layout of line numbers shrinking into nothing) - rust-lang#105972 (rustdoc: simplify section anchor CSS) - rust-lang#105973 (Avoid going through the happy path in case of non-fn builtin calls) - rust-lang#105976 (Remove unused `check-stage2-T-arm-linux-androideabi-H-x86_64-unknown-linux-gnu` make rule) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i686-apple-darwin should use
-arch i386instead of-arch i686